PHPStan Extension #15
Open
+41
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-dent
requested review from
edenchazard,
williamrenfrew and
willpower232
williamrenfrew
approved these changes
Nov 29, 2025
edenchazard
approved these changes
Dec 2, 2025
Member
edenchazard
left a comment
edenchazard
left a comment
There was a problem hiding this comment.
With dropping L9 support, it's possible we can now drop the backwards compatibility here too https://github.com/SynergiTech/laravel-magic-enums/blob/main/src/Commands/GenerateCommand.php#L229 but no biggie
Contributor
Author
I kinda left support for L9 in, just not tests.. I don't think we have any L9 projects with magic enums in, but not entirely sure.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tells stan that constants that are decorated with one of our magic attributes are in fact used.